Make helpers default depend on export_all
#259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #244
The testthat helpers are sourced into the pkgload env, and these might depend on non-exported bindings. Sourcing the helpers by default when
export_all = FALSEwill cause unexpected behaviour in that case. This patch changes the default to matchexport_all.In particular, this makes
devtools::run_examples()more reliable.Ideally I'd make
export_all = FALSE, helpers = TRUEan error, but I don't have a sense of how much of a breaking change that would be for devtools-based tools.