Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkgbuild::with_build_tools() in rcmcheck #111

Closed
jimhester opened this issue Aug 23, 2019 · 0 comments · Fixed by #157
Closed

Use pkgbuild::with_build_tools() in rcmcheck #111

jimhester opened this issue Aug 23, 2019 · 0 comments · Fixed by #157
Labels
feature a feature request or enhancement

Comments

@jimhester
Copy link
Member

Right now rcmdcheck doesn't ensure the build tools are on the PATH, so you can get failures on Windows even if you have RTools installed unless you explicitly use pkgbuild::with_build_tools(). We could have rcmdcheck instead do this automatically.

Note RStudio does put RTools on the PATH when you run it via the build pane, but not if you run directly in the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants