Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite session info extraction #164

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Rewrite session info extraction #164

merged 3 commits into from
Sep 23, 2021

Conversation

gaborcsardi
Copy link
Member

Do not require fake profiles, use R_TESTS instead.

Do not require fake profiles, use R_TESTS instead.
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #164 (75abcd8) into master (cabc75f) will decrease coverage by 0.45%.
The diff coverage is 76.78%.

❗ Current head 75abcd8 differs from pull request most recent head d2b9cf0. Consider uploading reports for the commit d2b9cf0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   81.09%   80.63%   -0.46%     
==========================================
  Files          19       19              
  Lines        1005     1007       +2     
==========================================
- Hits          815      812       -3     
- Misses        190      195       +5     
Impacted Files Coverage Δ
R/session-info.R 54.16% <42.10%> (-13.84%) ⬇️
R/background.R 93.75% <94.44%> (-1.25%) ⬇️
R/package.R 87.09% <94.73%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cabc75f...d2b9cf0. Read the comment docs.

This is needed because callr has a bug when
the sub-process ignores .Renviron and .Rprofile, but
a sub-sub-process does not.

Closes #134.
@gaborcsardi gaborcsardi merged commit adfdf73 into master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants