Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation failure is not reported #350

Open
be-marc opened this issue Nov 18, 2022 · 4 comments
Open

Installation failure is not reported #350

be-marc opened this issue Nov 18, 2022 · 4 comments

Comments

@be-marc
Copy link

be-marc commented Nov 18, 2022

I checked the package mlr3tuning and the installation of the reverse dependency mlr3verse failed in new and old. This is recorded in the 00check.log files:

* using log directory/home/ubuntu/mlr3tuning/revdep/checks/mlr3verse/new/mlr3verse.Rcheck* using R version 4.2.2 (2022-10-31)
* using platform: x86_64-pc-linux-gnu (64-bit)
* using session charset: UTF-8
* using options--no-manual --no-build-vignettes* checking for filemlr3verse/DESCRIPTION... OK
* this is packagemlr3verseversion0.2.6* package encoding: UTF-8
* checking package namespace information ... OK
* checking package dependencies ... ERROR
Packages required but not available: 'mlr3hyperband', 'mlr3tuningspaces'

See sectionThe DESCRIPTION filein theWriting R Extensionsmanual.
* DONE
Status: 1 ERROR

But this is not recorded in failures.md, problems.md, readme.md and cran.md. I only could see this in the print of revdepcheck::revdep_check(). I don't know why the installation failed but this should still be recorded, right?

@xrobin
Copy link

xrobin commented Jul 2, 2023

This is an interesting development of #209.

I must say I got hit by it today - I should have suspected that all checks being OK was weird.

Summary reports everything as OK...

> revdepcheck::revdep_summary()
✔ aplore3 0.9                            ── E: 0     | W: 0     | N: 0    
✔ arsenal 3.6.3                          ── E: 0     | W: 0     | N: 0    
✔ AutoScore 1.0.0                        ── E: 0     | W: 0     | N: 0    
✔ bbl 1.0.0                              ── E: 0     | W: 0     | N: 0    
✔ BDgraph 2.72                           ── E: 0     | W: 0     | N: 0    
✔ Biocomb 0.4                            ── E: 0     | W: 0     | N: 0    
✔ BioPET 0.2.2                           ── E: 0     | W: 0     | N: 0    

However this is clearly not the case, with dependencies that weren't installed:

> revdepcheck::revdep_details(pkg=".", "AutoScore")
══ Reverse dependency check ═════════════════════════════════════════════════════════════════════════════════════ AutoScore 1.0.0 ══

Status: OK

── Before ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
❯ checking package dependencies ... ERROR
  Packages required but not available:
    'tableone', 'car', 'coxed', 'ordinal', 'tidyr', 'randomForestSRC',
    'survAUC', 'survminer'
  
  See section ‘The DESCRIPTION file’ in the ‘Writing R Extensions’
  manual.

1 error ✖ | 0 warnings ✔ | 0 notes ✔

── After ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
❯ checking package dependencies ... ERROR
  Packages required but not available:
    'tableone', 'car', 'coxed', 'ordinal', 'tidyr', 'randomForestSRC',
    'survAUC', 'survminer'
  
  See section ‘The DESCRIPTION file’ in the ‘Writing R Extensions’
  manual.

1 error ✖ | 0 warnings ✔ | 0 notes ✔

This is with a revdepcheck installed a few minutes ago.

@MLopez-Ibanez
Copy link

Same as #343 ?

@MLopez-Ibanez
Copy link

Same as #219

@MLopez-Ibanez
Copy link

Same as #256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants