Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renv integrations? #74

Closed
edavidaja opened this issue May 26, 2022 · 4 comments · Fixed by #98
Closed

renv integrations? #74

edavidaja opened this issue May 26, 2022 · 4 comments · Fixed by #98
Labels
feature a feature request or enhancement

Comments

@edavidaja
Copy link

Thank you for this tool! I think it's going to make lots of people's workflows a whole lot easier.

I mostly use renv to manage projects; since the renv.lock captures the version of R I snapshotted the library with, it would be cool if I could use rig to start RStudio with the correct version of R, and possibly with the library specified with the lockfile.

@gaborcsardi
Copy link
Member

Yeah, rig rstudio could take a lock file. One difficulty is deciding what to do if that R version is not installed? On macOS you cannot install different patch versions for the same minor version (ie. R x.y.z1 and x.y.z1) together, so if different lock files request these, then it is quite painful to switch back and forth?

@gaborcsardi gaborcsardi added the feature a feature request or enhancement label May 27, 2022
@gaborcsardi
Copy link
Member

@edavidaja So what do you think rig should do if that version is not installed? What if only the minor version is the different? E.g. the project wants 4.1.2, but 4.1.2 is installed?

Here's what I think:

  • If the same exact version is installed, start that, obviously.
  • If the same minor version is installed, i.e. 4.1.x for requested 4.1.y, then give a warning and use 4.1.x.
  • Otherwise stop and error.

@edavidaja
Copy link
Author

That sounds reasonable to me. The "nearest" matching algorithm used by connect is somewhat more permissive but I think major-minor is a sane default.

@aspeddro
Copy link
Contributor

aspeddro commented Jun 2, 2022

A suggestion, I don't know if it's in the scope of rig

  • A command to install package dependencies and R version in renv.locK, similar to npm install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants