Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Wrap on_load() contents in examples with braces #1697

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Mar 12, 2024

This gives better tracebacks, I suppose.

@lionel-
Copy link
Member

lionel- commented Mar 13, 2024

How does it give better tracebacks?

@krlmlr
Copy link
Member Author

krlmlr commented Mar 13, 2024

I've noticed that srcrefs are available only for braced expressions, not for naked ones. Can't vouch for this specific case, but observed with expect_snapshot() . @hadley: would you like to share your perspective?

@lionel-
Copy link
Member

lionel- commented Mar 13, 2024

oh yeah that's definitely the case

@lionel- lionel- merged commit baedaca into main Mar 13, 2024
1 of 12 checks passed
@lionel- lionel- deleted the f-onload-braces branch March 13, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants