Add r_dyn_raw_push_back() and r_dyn_chr_push_back()
#1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
commented
Mar 28, 2024
Comment on lines
1007
to
1013
| arr <- new_dyn_vector("logical", 3) | ||
| dyn_push_back(arr, TRUE) | ||
| dyn_lgl_push_back(arr, TRUE) | ||
| expect_equal(dyn_lgl_get(arr, 0L), TRUE) | ||
| expect_equal(dyn_lgl_get(arr, 1L), TRUE) | ||
| dyn_lgl_poke(arr, 0L, FALSE) | ||
| expect_equal(dyn_lgl_get(arr, 0L), FALSE) |
There was a problem hiding this comment.
Each test here tested the generic push API, the poke API, and the get API for each type. I've just extended these tests to also test the typed push API
|
Test failures seem unrelated but definitely worth taking a look at, as it seems important? |
lionel-
approved these changes
Apr 5, 2024
DavisVaughan
force-pushed
the
feature/dyn-chr-push
branch
from
b542de6 to
6172b94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 missing push-back helpers.
In #1542 I optimized the push-back API by separating it from the generic
r_dyn_push_back()helper. This was nice, but it left the typed push back API untested. In addition to adding those 2 missing helpers, this PR also adds the missing tests for the typed API.