Improve check for unexported S3 methods

Fixes #1593
r-lib · Feb 9, 2024 · 30a4595 · 30a4595
1 parent db4dd9a
commit 30a4595
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/R/namespace.R b/R/namespace.R
@@ -398,8 +398,9 @@ warn_missing_s3_exports <- function(blocks, env) {
 
   s3blocks <- blocks[map_lgl(blocks, block_has_tags, c("export", "exportS3method"))]
   s3objects <- map(blocks, function(block) block$object$value)
+  s3functions <- Filter(is.function, s3objects)
 
-  undocumented <- methods[!methods %in% s3objects]
+  undocumented <- methods[!methods %in% s3functions]
   srcrefs <- map(undocumented, attr, "srcref")
 
   map2(undocumented, names(undocumented), function(fun, name) {