You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Similar problem to #1347 caused by the fix for #950, but in this case it seems to me the old behavior was correct. We have ?substr:
...
substr(x, start, stop)
substring(text, first, last = 1000000L)
...
Arguments
x, text a character vector.
start, first integer. The first element to be extracted or replaced.
...
In fansi I have @inheritParams base::substr, which with previous roxygen2 produced the desired correct outcome.
Would you consider a PR to do a second matching pass to recover the correct old behavior in cases like these? Of course it is the user's responsibility to make sure that inheriting a subset of joint parameters like this makes sense as it does here (less so with e.g. taking just x out of x,y from merge).
## v1.0.6
* Fix new `-Wformat` warnings.
## v1.0.5
* Address roxygen2 breaking changes:
* Add explicit alias for `fansi-package` now that it is no longer
auto-generated by roxgen2 from the [`@docType package`
directive](r-lib/roxygen2#1491).
* Work around [changed behavior for
`@inheritParams`](r-lib/roxygen2#1515).
Similar problem to #1347 caused by the fix for #950, but in this case it seems to me the old behavior was correct. We have
?substr
:In
fansi
I have@inheritParams base::substr
, which with previous roxygen2 produced the desired correct outcome.Would you consider a PR to do a second matching pass to recover the correct old behavior in cases like these? Of course it is the user's responsibility to make sure that inheriting a subset of joint parameters like this makes sense as it does here (less so with e.g. taking just
x
out ofx,y
frommerge
).A code example showing the failure to inherit:
vs
The text was updated successfully, but these errors were encountered: