Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to files, not topics #1109

Merged
merged 24 commits into from
Jun 26, 2020
Merged

Link to files, not topics #1109

merged 24 commits into from
Jun 26, 2020

Commits on Jun 11, 2020

  1. Link to files, not topics #1: external links

    @gaborcsardi
    gaborcsardi committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    15ca334 View commit details
    Browse the repository at this point in the history

  2. Link to files, for internal links as well

    @gaborcsardi
    gaborcsardi committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    ce56cdd View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2020

  1. Link to files, in re-exports as well.

    @gaborcsardi
    gaborcsardi committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    501d8a5 View commit details
    Browse the repository at this point in the history

  2. Use dev rmarkdown, to work around a bug in the CRAN version 

    rstudio/rmarkdown#1831
    @gaborcsardi
    gaborcsardi committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    b533014 View commit details
    Browse the repository at this point in the history

  3. Do not link to file, if not needed 

    I.e. if the name of the topic is the same as the
name of the file, then we are ok.
    @gaborcsardi
    gaborcsardi committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    adb089d View commit details
    Browse the repository at this point in the history

  4. Link to files refactoring 

    Also implement proper warnings, with file names
and line numbers, for re-exports as well.
    @gaborcsardi
    gaborcsardi committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    a86e14c View commit details
    Browse the repository at this point in the history

  5. Add test to auto-linking to file

    @gaborcsardi
    gaborcsardi committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    66f00cd View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2020

  1. Fix qualified links to the dev package

    @gaborcsardi
    gaborcsardi committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    683941f View commit details
    Browse the repository at this point in the history

  2. Add dev docs for linking to file names

    @gaborcsardi
    gaborcsardi committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    fe7dda7 View commit details
    Browse the repository at this point in the history

  3. Do not warn for unknown links 

    This is R CMD check's job.
    @gaborcsardi
    gaborcsardi committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    873f8cc View commit details
    Browse the repository at this point in the history

  4. Link to file for cross-package qualified links 

    But leave the rest of the links alone.
    @gaborcsardi
    gaborcsardi committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    8819f9a View commit details
    Browse the repository at this point in the history

  5. NEWS entry for linking to files

    @gaborcsardi
    gaborcsardi committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    1e063d9 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2020

  1. Add tests for unknown files/topics in re-exports

    @gaborcsardi
    gaborcsardi committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    b30da61 View commit details
    Browse the repository at this point in the history

  2. Fix link in note of @inheritDotParams 

    We need to link to the file, not the topic.
    @gaborcsardi
    gaborcsardi committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    e8dece5 View commit details
    Browse the repository at this point in the history

  3. Fix links in inherited docs 

    We need to link to the file, instead of the topic.
    @gaborcsardi
    gaborcsardi committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    be0fd82 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
    @gaborcsardi @hadley
    gaborcsardi and hadley authored Jun 18, 2020
    Configuration menu
    Copy the full SHA
    1c2f7e6 View commit details
    Browse the repository at this point in the history

  2. Link-to-file: fix comment

    @gaborcsardi
    gaborcsardi committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    2db56ed View commit details
    Browse the repository at this point in the history

  3. Fix vectorization in inherited links 

    That we just broke...
    @gaborcsardi
    gaborcsardi committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    51ecc2d View commit details
    Browse the repository at this point in the history

  4. Refactor linked file finding code

    @gaborcsardi
    gaborcsardi committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    5cd97dc View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Don't need dev rmarkdown any more

    @gaborcsardi
    gaborcsardi committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    59bdd0f View commit details
    Browse the repository at this point in the history

  2. Close a dangling connection

    @gaborcsardi
    gaborcsardi committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    e7de910 View commit details
    Browse the repository at this point in the history

  3. Refactor link-to-file helpers

    @gaborcsardi
    gaborcsardi committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    9947c05 View commit details
    Browse the repository at this point in the history

  4. Do not qualify links to the current package 

    R searches for topics in the linking package itself
first, so these are not need to be qualified.

Ignoring the 'mypackage::' part helps moving code
between packages, e.g. for compat files.
    @gaborcsardi
    gaborcsardi committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    3dc1b0e View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. merge origin/master

    @hadley
    hadley committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    e54d06c View commit details
    Browse the repository at this point in the history