Ignore self-import directives #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The snapshot failures also happen with main. |
hadley
reviewed
Nov 2, 2023
lionel-
force-pushed
the
discard-current-pkg
branch
from
bcdd464
to
aac8a0c
Compare
hadley
reviewed
Nov 6, 2023
hadley
approved these changes
Nov 6, 2023
lionel-
force-pushed
the
discard-current-pkg
branch
from
aac8a0c
to
4f02838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm not missing anything that's all that is needed to provide a solution for r-lib/usethis#1853. With this PR, an
#' @import(foo)directive is ignored when documenting the package foo. This makes it possible for standalone files to define their self dependencies.