Add a .devcontainer #1571
Merged
Add a .devcontainer #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to include with the caveat that we won't maintain it, so if any problems crop up with it I'll be cc'ing you 😄 |
|
makes sense+SGTM! hopefully it's of use to some others :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to develop roxygen2 directly from the browser with GitHub Codespaces.
One nice side effect is encapsulating (in the Dockerfile) the minimal setup needed to get roxygen2 prepared for development locally.
Config/Needs/development is a way to strike a balance between installing all of Imports+Suggests (takes longer to build the container) and missing some pieces essential to development (testthat's a good example -- you can't really do most dev work without running the test suite --> need testthat).
In {lintr}, we also added {pkgload} here since that is used a lot in dev workflow. ({roxygen2} already Imports {pkgload}, of course):
https://github.com/r-lib/lintr/blob/bad1632f23b77f41cec13fb6f1c883302f64f506/DESCRIPTION#L55