Skip to content

Conversation

@jennybc
Copy link
Member

@jennybc jennybc commented Jul 15, 2025

is_renv_project is the poster child for this change

Basically no amount of reasonable regex work, on the here side, leads to valid .Rd when you print the desc for the criteria, if we try to embed double quotes inside double quotes. I'm sure it's possible, but just incredibly fiddly. The problem can be designed away by using reserving double quotes for the regexes themselves (like the one used in renv.lock) and use single quotes to quote.

@jennybc jennybc requested a review from krlmlr July 17, 2025 21:35
@krlmlr krlmlr changed the title Use single quotes to avoid nested double quotes docs: Use single quotes to avoid nested double quotes Aug 3, 2025
@krlmlr krlmlr merged commit 673efad into main Aug 3, 2025
5 checks passed
@krlmlr krlmlr deleted the swap-single-quotes-for-double branch August 3, 2025 07:50
@krlmlr
Copy link
Member

krlmlr commented Aug 3, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants