Skip to content

Conversation

@gadenbuie
Copy link
Contributor

A small PR to add an is_renv_project criterion that finds an renv.lock file containing "Packages": {. I needed this in a project and thought it might be broadly useful to others.

I updated documentation but not the snapshot tests as I'm running into odd testthat and pkgload errors that are likely specific to my machine and that I don't have time to diagnose at the moment. Hopefully it'll be easy for you to update the snapshots.

@krlmlr krlmlr force-pushed the renv-project-criterion branch from 3a2b9be to d7d2cc9 Compare September 1, 2023 08:30
@aviator-app
Copy link
Contributor

aviator-app bot commented Nov 5, 2023

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@aviator-app aviator-app bot added the blocked label Nov 5, 2023
@aviator-app
Copy link
Contributor

aviator-app bot commented Nov 5, 2023

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Remove the blocked label to re-queue.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).

@krlmlr
Copy link
Member

krlmlr commented Nov 5, 2023

Yeah, updating the snapshot is tricky -- requires installing the package and running testthat::test_local(load_package = "none") . I can handle that.

@krlmlr krlmlr removed the blocked label Nov 5, 2023
@krlmlr krlmlr changed the title Add is_renv_project criterion looking for an renv.lock file feat: Add is_renv_project criterion looking for an renv.lock file Nov 5, 2023
@aviator-app aviator-app bot added the blocked label Nov 5, 2023
@krlmlr krlmlr force-pushed the renv-project-criterion branch from d7d2cc9 to 28f7e74 Compare November 5, 2023 06:20
@aviator-app
Copy link
Contributor

aviator-app bot commented Nov 5, 2023

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Remove the blocked label to re-queue.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).

@krlmlr krlmlr removed the blocked label Nov 5, 2023
@aviator-app aviator-app bot added the blocked label Nov 5, 2023
@aviator-app
Copy link
Contributor

aviator-app bot commented Nov 5, 2023

This pull request failed to merge: some CI status(es) failed. Remove the blocked label to re-queue.

Failed CI(s): Smoke test: stock R

@krlmlr krlmlr removed the blocked label Nov 5, 2023
@krlmlr
Copy link
Member

krlmlr commented Nov 5, 2023

Thanks for the PR!

@aviator-app aviator-app bot merged commit bd8cbf2 into r-lib:main Nov 5, 2023
@olivroy olivroy mentioned this pull request Nov 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants