Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #480.
For discrete training,
is.factor(x)
is swapped out by!is.null(levels(x))
.That way, any custom class that implements
levels.custom()
should be able to train a range.For continuous training, we require the result of
range(x)
to be numeric (rather than x itself).Error message is slightly terser, but that isn't too bad.
Created on 2024-11-19 with reprex v2.1.1