Ensure JunitReporter alway uses . for decimal (#1885)

Fixes #1660
r-lib · Oct 19, 2023 · 5550c98 · 5550c98
1 parent c0845db
commit 5550c98
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,8 @@
 # testthat (development version)
 
+* `JunitReporter()` now uses ensures numeric values are saved the xml file 
+  with `.` as decimal separator. (@maksymiuks, #1660)
+
 # testthat 3.2.0
 
 ## Lifecycle changes

diff --git a/R/reporter-junit.R b/R/reporter-junit.R
@@ -85,6 +85,8 @@ JunitReporter <- R6::R6Class("JunitReporter",
     },
 
     end_context = function(context) {
+      # Always uses . as decimal place in output regardless of options set in test
+      withr::local_options(list(OutDec = "."))
       xml2::xml_attr(self$suite, "tests") <- as.character(self$tests)
       xml2::xml_attr(self$suite, "skipped") <- as.character(self$skipped)
       xml2::xml_attr(self$suite, "failures") <- as.character(self$failures)
@@ -96,6 +98,7 @@ JunitReporter <- R6::R6Class("JunitReporter",
     },
 
     add_result = function(context, test, result) {
+      withr::local_options(list(OutDec = "."))
       self$tests <- self$tests + 1
 
       time <- self$elapsed_time()