Add in_snapshotter()
and return conditions visibly when snapshotting
#1505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently broken, because
in_snapshotter()
seems to always returnTRUE
when testing a file or directory, and always returnFALSE
when running a test interactively. Both of these are incorrect.We need something that is more fine grained. I think
expect_snapshot()
itself might need to set something that announces that you are "in a snapshot expectation". That would mean that both interactive and non-interactive testing could return visible conditions where appropriate.