Skip to content

Remove usage of cpp11's CPP11_UNWIND #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #414
DavisVaughan opened this issue Dec 3, 2024 · 0 comments
Closed
Tracked by #414

Remove usage of cpp11's CPP11_UNWIND #47

DavisVaughan opened this issue Dec 3, 2024 · 0 comments

Comments

@DavisVaughan
Copy link
Member

textshaping/src/utils.h

Line 23 in 841a1dd

CPP11_UNWIND \

Like with r-lib/systemfonts#119, we don't need CPP11_UNWIND anymore because R_ContinueUnwind() is now always available. If you could please just inline R_ContinueUnwind(err); there instead in the next release, that would be great!

It currently looks removed in cpp11 but I'm going to bring it back to avoid breaking textshaping this time around.
@DavisVaughan DavisVaughan mentioned this issue Dec 3, 2024
Open
1 task
DavisVaughan added a commit to DavisVaughan/cpp11 that referenced this issue Dec 4, 2024
@DavisVaughan
Restore CPP11_UNWIND for textshaping
f4baccc 
r-lib/textshaping#47
DavisVaughan added a commit to r-lib/cpp11 that referenced this issue Dec 4, 2024
@DavisVaughan
Restore CPP11_UNWIND for backwards compatibility (#415)
ed8e1da 
* Restore `CPP11_UNWIND` for textshaping

r-lib/textshaping#47

* Update some links

* Collapse the NEWS bullet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavisVaughan