Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use_package() min_version will not decrement #1957

Closed
JosiahParry opened this issue Mar 1, 2024 · 2 comments · Fixed by #2043
Closed

use_package() min_version will not decrement #1957

JosiahParry opened this issue Mar 1, 2024 · 2 comments · Fixed by #2043
Labels
description 📚 tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day

Comments

@JosiahParry
Copy link
Contributor

When min_version is provided and it is a smaller semver than the one currently in the DESCRIPTION file, it will not be decremented to the lower version.

usethis::use_package("dplyr", min_version = "1.0.0")
usethis::use_package("dplyr", min_version = "0.8.0")
@jennybc
Copy link
Member

jennybc commented Jul 22, 2024

Tagging as "needs investigation" for tidyverse dev day.

Specifically: my hunch from skimming the code is that this behaviour is coming from the desc package and not something usethis has taken a stand on.

It would be great for someone to nail that down definitively.

@jennybc jennybc added description 📚 tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day labels Jul 22, 2024
jplecavalier added a commit to jplecavalier/usethis that referenced this issue Aug 15, 2024
@jplecavalier
Let use_package() decrement a package dependency. Fixes r-lib#1957.
6d8e65d
@jplecavalier jplecavalier mentioned this issue Aug 15, 2024
Merged
@JosiahParry
Copy link
Contributor Author

🎉 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
description 📚 tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Let use_package() decrement a package dependency. jplecavalier/usethis
2 participants
@jennybc @JosiahParry