Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1822
Probably better to merge #1990 first.
If merged, I will add some pointer in https://testthat.r-lib.org/articles/special-files.html#helper-files.
Considerations:
Test interactively: be able to jump the 3 files easily R/mocks.R, tests/testthat/test-mocks.R and tests/testthat/helper-mocks.R
.
use_test_helper() # will go to specific associated helper file if exists or tests/testthat/helper.R otherwise
In usethis, I'd type the 3 functions successively starting with mocks.R to see that the 3 way workflow works as expected.
A case I have not considered:
if multiple
tests/testthat/helper-{file}.R
exist, but nottests/testthat/helper.R
, but nottests/testthat/helper-foofy.R
, it would probably be better to have it than what I currently implemented (tests/testthat/helper.R
)Harder to jump back to test files or R from
tests/testthat/helper.R
, will create a possibly unwanted file. I added a condition to prevent that.. 31d68a2