Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could proxy methods override object type(s)? #65

Closed
tobiasziegler opened this issue Feb 27, 2021 · 0 comments · Fixed by #88
Closed

Could proxy methods override object type(s)? #65

tobiasziegler opened this issue Feb 27, 2021 · 0 comments · Fixed by #88

Comments

@tobiasziegler
Copy link

The compare_proxy methods are currently called after types have been compared, which means a proxy method can't have any effect on the objects in time for those comparisons.

One specific use case for calling proxy methods ahead of type comparison would be to support comparing strings created using glue to ordinary strings - see tidyverse/glue#212 about the current situation testing glue output with testthat 3e and workarounds.

I'm not sure if this change is workable - if not then hopefully raising this issue and the linked one point people to the way to handle testing with glue output in testthat 3e. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant