Remove usage of metaprogramming in device helpers #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the weird variable binding errors are caused by |
hadley
reviewed
Jul 30, 2024
R/devices.R
Outdated
|
|
||
| pdf_dev <- function(filename, ...) { | ||
| grDevices::pdf(file = filename, ...) | ||
| grDevices::dev.cur() |
There was a problem hiding this comment.
I'd be tempted to move the dev.cur() in to the local_* functions. Then you could remove all the shims except for those necessary to standardise the argument names.
There was a problem hiding this comment.
Good idea. How does this now look? I've also abstracted device closing in a defer_dev_close() helper.
oh no :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the R-devel warning. It seems more robust not to inline programmatically the arguments in generated functions so I've now hardcoded the implementations. For simplicity arguments are passed via
...and the documentation now contains a list of links to wrapped functions so the relevant signatures can be browsed by following the links.Does this seem reasonable enough @hadley ?
I was also expecting these notes to disappear following this change:
Somehow they're still there.