-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lidRviewer 1.0.0 announcement #23
Comments
Oooo... exciting! |
|
@bi0m3trics Thank you for your test. When I wrote arbitrary large I was not thinking about 879 millions points. I guess some optimization will be required to make the initial indexing faster and smoother. But ultimately it works. ✅ Straightforward installation |
@Jean-Romain |
Just tested it on Windows, and everything looks good on my end. However, you don't have eye dome lighting (EDL) because the points are too small, which also causes the rendering to degrade. The EDL doesn’t work well when applied to such small points. Try disabling EDL when the points are too small—the rendering should improve (and be faster). I also watched your second video. Thank you very much for taking the time to create it. I see a few possible improvements:
Thank you very much again. |
Of course... and I think it's absolutely great! |
FYI: opening a @bi0m3trics I fixed an issue with an incorrect hard coded field of view value. I think know the rendering of the density should be better. What triggers me is that the edges of your rendering were rendered with very low density. Can you retry please. |
Hey JR, This is a great and welcomed addition to the r-lidar ecosystem! On my end mostly its working well, however I experience some clipping issues with the eye-dome lighting - see video, Otherwise decreasing point cloud size is working well but increasing is not. https://www.youtube.com/watch?v=Ce14ZEMZ4yY Here are the specs of the laptop I used: Intel Core Ultra 9 185H, 32GB RAM, NVIDIA GeForce RTX 4060 Laptop GPU, x64-based PC, at 2560x1600, running Windows 11 Home (Version 10.0.22631) Cheers Liam |
Thank you for you feed back and incredible edited video where I can see the keys you are pressing. Which software did you use?
You input is very valuable thank you. |
Thanks JR, glad its helpful... The EDL issue seems to be apparent for me when full-screening the rendering, it seems to work fine when the viewer first opens I did retry increasing the point size and it does work using the numpad's +/-, just not using the normal (shift +=) I use. The tool I used to visualize keystrokes is called keyviz check it out here: https://github.com/mulaRahul/keyviz Happy to continue testing the viewer as you make changes! Liam |
Ok, same for me. So I can fix on my end.
Ok. It is an helpful information. |
@liamirwin The EDL issue should be fixed now |
The
devel
branch contains the version 1.0.0 which is complete redesign of the package. @H4estu @caiohamamura @ptompalski @liamirwin may I ask you to test it and provide feedback. It is designed to efficiently display arbitrarily large in-memory point clouds, with tested cases including over 130 million points.Usage
Use
library(lidRviewer)
afterlibrary(lidR)
to overide the defaultrgl
plot function fromlidR
.The text was updated successfully, but these errors were encountered: