Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create geoms for lotri/utri_heatmap, *_heatpoint and *_heatcircle #23

Open
r-link opened this issue Jul 27, 2020 · 1 comment
Open

Create geoms for lotri/utri_heatmap, *_heatpoint and *_heatcircle #23

r-link opened this issue Jul 27, 2020 · 1 comment

Comments

@r-link
Copy link
Owner

r-link commented Jul 27, 2020

At the moment, these functions are all implemented as stats - this means that the position computed in the compute_panel() step is not validated in the draw_panel() step and may be off if the plotting range is modified by quantities computed from other stats (like CIs for geom_smooth()) or by additional layers with external data.

TODO:

  • write geoms with a draw_panel() step analogous to geom_reltext() to replace or complete the existing stats,
  • check if stat_corrtext/funtext() can be used to calculate the necessary data - if not, adjust existing stats,
  • rewrite the corresponding utri_/lotri_ functions.
r-link added a commit that referenced this issue Aug 3, 2020
Allows to split heatpoints by group (cf. #23).
@r-link
Copy link
Owner Author

r-link commented Aug 3, 2020

Update:

  • *_heatmap() and *_heatpoint() have an improved functionality,
  • *_heatcircle() still needs a geom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant