Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with upcoming review policy #39

Merged
merged 26 commits into from
Nov 23, 2024
Merged

Conversation

wlandau
Copy link
Member

@wlandau wlandau commented Nov 20, 2024

This PR updates our contribution reviews to align with the upcoming revision to the review policy: r-multiverse/r-multiverse.github.io#33, r-multiverse/help#103. I tested most of the cases (most of the old scenarios, all the new ones) using https://github.com/r-multiverse/contributions-dev, and it appears to be working.

@wlandau
Copy link
Member Author

wlandau commented Nov 20, 2024

NB this PR closes r-multiverse/help#77,

@wlandau
Copy link
Member Author

wlandau commented Nov 20, 2024

also fixes r-multiverse/help#83

@wlandau wlandau mentioned this pull request Nov 22, 2024
@wlandau
Copy link
Member Author

wlandau commented Nov 23, 2024

Thanks @shikokuchuo for confirming by email that you're okay with merging this.

@wlandau wlandau merged commit dfc9907 into r-multiverse:main Nov 23, 2024
5 of 6 checks passed
@wlandau wlandau deleted the review branch November 23, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants