Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization #7

Closed
wlandau opened this issue Jan 7, 2019 · 4 comments
Closed

Visualization #7

wlandau opened this issue Jan 7, 2019 · 4 comments

Comments

@wlandau
Copy link
Member

wlandau commented Jan 7, 2019

I have been struggling to profile drake for a long time because of r-lib/profvis#104, and this weekend, profile helped me really break through: ropensci/drake#647, https://github.com/wlandau/drake-examples/tree/master/overhead. A big piece of the solution was pprof's ability to spin up a Jupyter-like web server to display interactive visuals: pprof -http=0.0.0.0:8080 output_from_write_pprof.proto.

Do you think a front-end to this functionality would fall in scope for profile or maybe another package in the r-prof org? In my opinion, it could be a really useful high-performance alternative to profvis.

@krlmlr
Copy link
Member

krlmlr commented Jan 7, 2019

Thanks. The README for jointprof, https://r-prof.github.io/jointprof/, has an example that uses system2() to achieve this. Are you suggesting to add a wrapper around the shell commands?

@wlandau
Copy link
Member Author

wlandau commented Jan 7, 2019

That README is really helpful. When I last tried jointprof for an Rcpp-powered project at work, it was having trouble combining the R results with the C results, but that problem appears to be fixed now.

I think a wrapper around system2() would add convenience, draw more attention to the interactive visuals, and educate users on how to set the hostname/IP and port. Admittedly, I struggled with this last bit because I was working through an ssh session and had to use a different computer to run the browser. Jupyter notebooks are nice because they give you a link that just works, and pprof by itself is not as helpful.

@wlandau
Copy link
Member Author

wlandau commented Jan 12, 2019

Just realized find_pprof() will come in handy, so maybe jointprof is a better place for the implementation. Moving to r-prof/jointprof#35.

@wlandau wlandau closed this as completed Jan 12, 2019
@github-actions
Copy link

github-actions bot commented Dec 8, 2020

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants