Use correct printf format for uintptr_t. #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fine on 64-bit systems, but warns on 32-bit systems:
```
trace_back_backtrace.c: In function 'cb_get_name_ip':
trace_back_backtrace.c:87:19: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'uintptr_t' {aka 'unsigned int'} [-Wformat=]
87 | sprintf(ip_buf, "%.16" PRIx64, pc);
| ^~~~~~ ~~
| |
| uintptr_t {aka unsigned int}
```
and similar for `trace_back_unwind.c`.
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=======================================
Coverage 85.57% 85.57%
=======================================
Files 13 13
Lines 201 201
=======================================
Hits 172 172
Misses 29 29
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fine on 64-bit systems, but warns on 32-bit systems:
and similar for
trace_back_unwind.c.I'm not sure how portable this format macro is; if not, I can add a cast instead.