Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cbind and rbind methods #371

Merged
merged 3 commits into from
Jan 18, 2025
Merged

Add cbind and rbind methods #371

merged 3 commits into from
Jan 18, 2025

Conversation

jranke
Copy link
Contributor

@jranke jranke commented Aug 12, 2024

Fixes #311

@Enchufa2
Copy link
Member

Thanks. This PR currently breaks quantities. I'd like to avoid that unless strictly necessary. Did you look into it by any chance?

@jranke
Copy link
Contributor Author

jranke commented Aug 13, 2024

Thanks. This PR currently breaks quantities. I'd like to avoid that unless strictly necessary. Did you look into it by any chance?

I had a quick look, but it gets a bit complicated. The proposed method cbind.units is called in errors:::propagate in the case of quantities and there it fails, because not all arguments have units. If the check for this is removed, it still fails, presumably because it does not handle the error attributes. I do not understand the interaction of the packages and classes well enough to solve this.

@Enchufa2
Copy link
Member

No problem. Let's put this on hold then until I find the time to have a look.

Also, apply the full class vector of the first argument for the result.
@JohnADawson
Copy link

@Enchufa2, when do you expect cbind and rbind to be added?

@Enchufa2
Copy link
Member

Enchufa2 commented Dec 4, 2024

I forgot about this PR, thanks for the reminder. I'll take a look to try to push an update to CRAN in January with this.

@Enchufa2
Copy link
Member

Ok, so I'll have to land fixes for quantities and errors first, but this is good to go. Thanks for the contribution!

@Enchufa2 Enchufa2 merged commit 84fc092 into r-quantities:main Jan 18, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cbind and rbind silently drop units
3 participants