More assertions #55
More assertions #55
Conversation
… of array with one item.
…a. Integrated custom asymmetric matchers for Jest.
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 90.04% 90.71% +0.66%
==========================================
Files 8 9 +1
Lines 201 237 +36
Branches 28 29 +1
==========================================
+ Hits 181 215 +34
- Misses 20 22 +2
Continue to review full report at Codecov.
|
| res.status(404) | ||
| return res.json(error) | ||
| } | ||
| res.json(doc[0]) |
There was a problem hiding this comment.
This is significant if anyone uses it already. Probably makes more sense to return single item instead of array with single item.
|
Looks good, looked through the other repos and didn't see anyone using the latest endpoint for anything live currently. I'll post a heads up about the change for those working on other projects 👍 |
|
I probably should split the latest endpoint change from this one. This is mostly about data that needs to get fixed in mongo and discussing options. Wanted to make some summary with current requests, but wasn't feeling well over the weekend. Feel free to have a look at lines that are commented out. Most are just fields that are missing in some entries and are present others. One field was inconsistent type IIRC, number/object, but don't remember off top of my head, hopefully I mentioned it in comment. Edit: Just realized it's already merged, nvm then :) |
Refs: #53
Still WIP, but wanted to make early PR to keep track of it against the issue.
I added asymmetric matchers to make tests a bit more readable. Spotted some inconsistencies in vehicles and did most of assertions on them. You can see the comments.