Second wave of assertions. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 90.71% 88.84% -1.88%
==========================================
Files 9 9
Lines 237 260 +23
Branches 29 36 +7
==========================================
+ Hits 215 231 +16
- Misses 22 29 +7
Continue to review full report at Codecov.
|
Srokap
commented
Nov 13, 2017
| } | ||
| expect(any).toHaveProperty("id", expect.any(String)) | ||
| expect(any).toHaveProperty("name", expect.any(String)) | ||
| expect(any).toEqual(new SpacexMass()) |
There was a problem hiding this comment.
On second thought we could just inherit from SpacexMass matcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #53
Just stuff I forgot to push before it got merged. General plan is to go over the problems, fix them in db and uncomment assertions that currently fail.