release s2 1.0-6

[edzer]

With @jeroen 's UCRT fix #122, and sf now importing s2, we should submit 1.0-6 to CRAN rather soon, as it breaks all UCRT builds that depend on s2 or sf. Is there any chance we can address the gcc-11 issue, using the s2geometry PR before doing so?

[paleolimbot]

I don't think so...the gcc11 thing is a huge change that will require some major (but completely internal) changes...perhaps replacing the entire vendored-in s2 code. I think you will want the UCRT patched version of s2 on CRAN for sf to be stable for a while.

On that front, maybe you could follow up on the s2geometry upstream PRs to ask for updates? They seem dormant and it's unclear to me if they are releasing a new version anytime soon (that would be the ideal time to fix the gcc11 issue). I followed up on one thread maybe a month ago and I wonder if they need another ping from a different source.

I'll do the release checklist tomorrow!

[jeroen]

I think this gcc-11 warning no longer appears in the latest builds of gcc-11. At least not in Fedora 34. I suspect it may have been a bug in an earlier build of gcc-11.

[edzer]

Thanks, that's hopeful! Also of interest to @appelmar , for gdalcubes.

[paleolimbot]

Thanks @jeroen for tracking down the gcc11 bug!