Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: update openssl + fix ucrt #122

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Windows: update openssl + fix ucrt #122

merged 2 commits into from
Jun 11, 2021

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Jun 10, 2021

Sync build with the openssl package, cf jeroen/openssl@7749563

@jeroen jeroen marked this pull request as draft June 10, 2021 13:37
@codecov-commenter
Copy link

Codecov Report

Merging #122 (f5e0c44) into master (9ee2b01) will not change coverage.
The diff coverage is n/a.

❗ Current head f5e0c44 differs from pull request most recent head f7816fd. Consider uploading reports for the commit f7816fd to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files          40       40           
  Lines        2987     2987           
=======================================
  Hits         2809     2809           
  Misses        178      178           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee2b01...f7816fd. Read the comment docs.

@jeroen jeroen marked this pull request as ready for review June 10, 2021 18:36
@jeroen
Copy link
Contributor Author

jeroen commented Jun 10, 2021

OK this is good to go now. I also had to refactor the Makevars file a little bit, additional benefit will be that the compiler can now better optimize this.

@paleolimbot
Copy link
Collaborator

Thank you!

@paleolimbot paleolimbot merged commit a766fe9 into r-spatial:master Jun 11, 2021
@edzer edzer mentioned this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants