Skip to content

removes --static #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2021
Merged

removes --static #1702

merged 2 commits into from
Jun 26, 2021

Conversation

edzer
Copy link
Member

@edzer edzer commented Jun 23, 2021

No description provided.

@rsbivand
Copy link
Member

rsbivand commented Jun 23, 2021

Could I suggest changing the test to try with --static first as a separate test, and if it fails remove it from PROJ_LIB_PATH and try again? Failing --static would be a message or warning, not an error. Would a Fedora CI assist in the future to detect unannounced policy changes?

I don't see any email traffic around 17/1 discussing anything like this.

On reconsideration, sf/configure.ac line 393 was testing PROJ_LIB_PATH=pkg-config proj --libs --static, not imposing static linking, so what probably needs to be removed is -lsqlite3 in line 433?

@edzer
Copy link
Member Author

edzer commented Jun 23, 2021

I have no recollection why --static was added, and cannot find any reason in the issues or PRs. Maybe it was done by accident, like a wild guess, by accident (..) not in a branch? If nobody remembers this, I suggest reverting.

@edzer edzer merged commit a8eea53 into master Jun 26, 2021
@edzer edzer deleted the no_static branch June 26, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants