moved servr to imports

DESCRIPTION

@@ -46,7 +46,8 @@ Imports:
     stats,
     s2,
     tmaptools (>= 3.1),
-    units (>= 0.6-1)
+    units (>= 0.6-1),
+    servr,
 Suggests:
     av,
     colorspace,
@@ -55,7 +56,6 @@ Suggests:
     knitr,
     maptiles,
     png,
-    servr,
     shiny,
     terra,
     testthat (>= 3.2.0),

R/spatial_terra.R

@@ -9,7 +9,7 @@ tmapShape.SpatRaster = function(shp, is.main, crs, bbox, unit, filter, shp_name,
 	ctabs = terra::coltab(shp)
 	cats = terra::levels(shp)
 
-	minmax = as.list(as.data.frame(terra::minmax(shp)))
+	minmax = as.list(as.data.frame(terra::minmax(shp, compute = all(!terra::hasMinMax(shp)))))
 
 	dt = data.table::setDT(terra::as.data.frame(shp, na.rm=FALSE))
 	dt[, tmapID__:=1L:nrow(dt)]

R/tmapLeafletRun.R

@@ -96,7 +96,6 @@ tmapLeafletRun = function(o, q, show, knit, args) {
 					paneHeight = -1
 				}
 				if (ide == "vscode") {
-					rlang::check_installed("servr")
 					# VSCode's viewer can't ignore cross-origin requests. Need to serve the
 					# map so assests can be read, e.g. .fgb files.
 					server <- servr::httd(
@@ -110,7 +109,6 @@ tmapLeafletRun = function(o, q, show, knit, args) {
 				viewer(url, height = paneHeight)
 			}
 		} else {
-			rlang::check_installed("servr")
 			viewerFunc = function(url) {
 				dir = get_url_dir(url)
 				switch(ide,

cran-comments.md

@@ -12,6 +12,16 @@
 
 * Running time examples decreased
 
+## Reresubmission note
+
+* Running time examples further decreased
+
+## Reverse dependency checks
+
+* MazamaSpatialPlots: contacted the author about this issue. He promised to submit an update to resolve this once tmap 4.0 is on CRAN.
+* spatialrisk: to solve this, we've moved servr from Suggests to Imports.
+* mapping: this is a minor note due to the change of argument names ("col" has been renamed to "color"). It does not effect the output.
+
 ## R CMD check results
 
 0 errors | 0 warnings | 0 note

examples/tm_rgb.R

@@ -1,3 +1,4 @@
+\dontrun{
 require(stars)
 file = system.file("tif/L7_ETMs.tif", package = "stars")
 
@@ -6,7 +7,6 @@ L7 = stars::read_stars(file)
 tm_shape(L7) +
 	tm_rgb()
 
-\dontrun{
 # the previous example was a shortcut of this call
 tm_shape(L7) +
 	tm_rgb(col = tm_vars("band", dimvalues = 1:3, multivariate = TRUE))