bugfix: fixes #193 #194
Merged
bugfix: fixes #193 #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you !! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minorfixes: dep & typo
Run
npm testsuccessfully.Run
npm run mochasuccessfully.test_screenshotsgenerates the same test pictures intestas there were intest/referenceand does not show any errorsI implemented tests for the new changes OR
These changes do not require tests because _____
NB I have not yet added tests to prevent regression of this issue. I will update this branch in the coming days for tests, but seeing it is somewhat a debilitating bug, I figured I would push the fix first. If merged, we should raise a separate issue for implementing tests for this issue
These changes fix Inconsistency saving after 'AddRegion' and 'SubstractRegion' #193 (github issue number if applicable).