Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add linkchecker to CI #33

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add linkchecker to CI #33

wants to merge 5 commits into from

Conversation

brunopgalvao
Copy link
Contributor

This PR adds the Linkspector to the CI on Pull Requests.

@Daanvdplas
Copy link
Collaborator

If you want reviews on this you should ask for it :)

@brunopgalvao
Copy link
Contributor Author

If you want reviews on this you should ask for it :)

Thanks for the reminder, will follow up with this once I finish the Pop presentation this week.

Copy link
Contributor

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has this been tested? If not, adding a simple manual trigger would do the trick.

@brunopgalvao
Copy link
Contributor Author

has this been tested? If not, adding a simple manual trigger would do the trick.

Tested here: brunopgalvao#2

@peterwht
Copy link
Contributor

has this been tested? If not, adding a simple manual trigger would do the trick.

Tested here: brunopgalvao#2

amazing!

@brunopgalvao
Copy link
Contributor Author

For good security practices, can we have a custom GitHub token with limited access created for this a linkspector action? I do not have permissions to manage/create tokens.

@Daanvdplas
Copy link
Collaborator

Would it be possible to have this working on all the links in the repo, not only the links in the PR?

@brunopgalvao
Copy link
Contributor Author

Would it be possible to have this working on all the links in the repo, not only the links in the PR?

Once we have

Would it be possible to have this working on all the links in the repo, not only the links in the PR?

Looking into this: UmbrellaDocs/action-linkspector#20

@brunopgalvao
Copy link
Contributor Author

Would it be possible to have this working on all the links in the repo, not only the links in the PR?

🪄

Done. Please approve & merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants