-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update gas parameters for a parachain, units, and miscellaneous fixes and cleanups #6
Conversation
Amazing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested after the rebase and works!
Only doubt is about the renaming of parachain-template-runtime
to frontier-parachain-runtime
in the code.
I changed to parachain-template-runtime
to keep consistency with the node binary name. The binary name has to be parachain-template-node
, so when we generate the Zombienet config file with pop-cli
, it works.
Just my opinion about naming, rest looks great.,
If you keep the renaming here you can merge: #4 after. Otherwise just close that PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand though why we change the names to frontier, and in #4 we change it back.
It closed the other PR to avoid more confusion. It made sense when it was opened but not after the merge or your PR where naming was changed already: https://github.com/r0gue-io/evm-parachain/pull/11/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R32. The binary name has to be called For consistency I would prefer to keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change frontier-parachain
to parachain-template
naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.