fix: remove unused folders after download contracts node binary #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #240 +/- ##
==========================================
- Coverage 70.34% 70.31% -0.03%
==========================================
Files 44 44
Lines 6787 6792 +5
Branches 6787 6792 +5
==========================================
+ Hits 4774 4776 +2
Misses 1240 1240
- Partials 773 776 +3
|
AlexD10S
requested review from
brunopgalvao,
al3mart,
peterwht,
evilrobot-01 and
Daanvdplas
evilrobot-01
reviewed
Jul 5, 2024
brunopgalvao
approved these changes
Jul 8, 2024
evilrobot-01
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the
substrate-contract-nodeis downloaded, the binary is extracted toartifacts/substrate-contracts-node-mac/substrate-contracts-node. This made the cargo clean cache process more complex as it was failing when trying to remove the folder.This PR fixes that by copying the binary to the root cache folder and removing the unnecessary folders.