-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to 1.9.0 #179
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## developer #179 +/- ##
==========================================
Coverage 10.58% 10.58%
==========================================
Files 27 27
Lines 2135 2135
Branches 2135 2135
==========================================
Hits 226 226
Misses 1909 1909
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in paritytech/polkadot-sdk#3002 should also be included :)
Maybe only for devnet (polkadot-fellows/runtimes#423)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I see no issues. Validated all PRs from here moondance-labs/tanssi#575
No need to do anything with this, but just documenting the following PR here in-case of async backing issues. paritytech/polkadot-sdk#3510
Will integration tests be resolved in a later version? |
[sc-916] |
I expect it will be resolved in a PR from 1.13.0 to 1.14.0 if I understand it correctly |
Integration tests are blocked until a new release of Paseo is done 🙏 |
POV reclaim feature is removed in this upgrade for both NOTE: For the POV reclaim feature, it will be cleaner in the next upgrade #182 with the introduction of unified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow even with the revert the host functions are still expected
Running both devnet
and testnet
will err with
Error: Service(Client(VersionInvalid("Other error happened while constructing the runtime: runtime requires function imports which are not present on the host: 'env:ext_storage_proof_size_storage_proof_size_version_1'")))
2024-08-15 11:05:16 [Parachain] Cannot create a runtime error=Other("runtime requires function imports which are not present on the host: 'env:ext_storage_proof_size_storage_proof_size_version_1'")
Approving as the objective is updating the codebase to current and it seems 1.10 gets rid of this. 👍
Thank you Ale, I also got this error on my end but with 1.10.0, it is fixed. So I guess this PR is good to be merged to |
Status: ✅ Tested on my local
devnet
,testnet
=> Block production / finalization + submit extrinsic works well.ISSUE: chore: upgrade to polkadot 1.14 #141
Reference
base-parachain
: https://github.com/r0gue-io/base-parachain/pull/9/filesRelease: https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.9.0
Compare
pallet-contracts
:v1.8.0
andv1.9.0
CHANGELOG
poll
hook and new System Callbacks (link to prdoc)as [disambiguation_path]
from the required syntax inderive_impl
Contracts-Related Changes
#3377 - Permissioned contract deployment
This PR introduces two new config types that specify the origins allowed to upload and instantiate contract code. However, this check is not enforced when a contract instantiates another contract.
Async Backing Issues