Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pallet-api/nonfungibles to runtime devnet #389

Open
wants to merge 24 commits into
base: chungquantin/feat-pallet_nonfungibles
Choose a base branch
from

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Nov 19, 2024

Description

  • Nonfungible API pallet will be registered with index 151 and configured on devnet runtime in this PR.
  • Configure Nonfungibles API in the devnet's chain extension.

@chungquantin chungquantin self-assigned this Nov 19, 2024
@chungquantin chungquantin linked an issue Nov 19, 2024 that may be closed by this pull request
20 tasks
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 96.49123% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.23%. Comparing base (80fe5f3) to head (5075c02).

Files with missing lines Patch % Lines
runtime/devnet/src/config/api/mod.rs 96.03% 4 Missing ⚠️
@@                            Coverage Diff                            @@
##           chungquantin/feat-pallet_nonfungibles     #389      +/-   ##
=========================================================================
+ Coverage                                  73.05%   73.23%   +0.18%     
=========================================================================
  Files                                         77       77              
  Lines                                      14628    14728     +100     
  Branches                                   14628    14728     +100     
=========================================================================
+ Hits                                       10686    10786     +100     
  Misses                                      3672     3672              
  Partials                                     270      270              
Files with missing lines Coverage Δ
runtime/devnet/src/config/assets.rs 100.00% <100.00%> (ø)
runtime/devnet/src/config/proxy.rs 0.00% <ø> (ø)
runtime/devnet/src/lib.rs 5.53% <ø> (ø)
runtime/devnet/src/config/api/mod.rs 89.85% <96.03%> (+22.41%) ⬆️

@chungquantin
Copy link
Collaborator Author

[sc-1242]

@chungquantin chungquantin force-pushed the chungquantin/feat-pallet_nonfungibles branch from 9516011 to d2d311d Compare December 16, 2024 03:56
@chungquantin chungquantin force-pushed the chungquantin/feat-runtime_nonfungibles branch from b5053be to 8d4ae0d Compare December 20, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(pop-api): nonfungibles use case
3 participants