refactor: tests for collection approval #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## chungquantin/feat-nfts #419 +/- ##
==========================================================
+ Coverage 70.48% 70.93% +0.44%
==========================================================
Files 72 72
Lines 13119 13313 +194
Branches 13119 13313 +194
==========================================================
+ Hits 9247 9443 +196
Misses 3600 3600
+ Partials 272 270 -2
|
Daanvdplas
commented
Jan 7, 2025
| @@ -2120,6 +2069,64 @@ fn cancel_approval_works() { | |||
| }); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn cancel_approval_ensures_no_active_collection_approval() { | |||
There was a problem hiding this comment.
Only removed the events test and another storage check as it was already checked in the cancel_approval_works test
Daanvdplas
commented
Jan 7, 2025
| ), | ||
| Ok(Some(WeightOf::clear_collection_approvals(limit)).into()) | ||
| ); | ||
| approvals = approvals - limit; |
There was a problem hiding this comment.
Added this approvals mutation and limit variable only
chungquantin
changed the title
chungquantin
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors some of the test by separating the e.g. approve_collection_transfer and force_approve_collection_transfer, and while doing so found some small improvements.