-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: subxt script to fund dev accounts via XCM #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! One thing to add is three queries to Pop Network to ensure that alice, bob and charlie have received the funds.
Just thinking about this a little, would it not make sense to add this as a command to the It then becomes a first-class citizen, usable whenever a network launched, rather than compiling another side-car executable and manually launching. It could remain as its own crate, e.g. pop-node-init and be wrapped in a default feature so that it can be compiled out for releases if necessary. I'm just thinking about the UX via Also - have the |
Unfortunately, it seems subxt has a bug with trimming metadata files (or I'm doing something wrong). Please see issue: paritytech/subxt#1509 |
Love the idea. This will be done in a separate PR as time allows. See tracker #57 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems the pop interface is missing?
Everything works! Got an error ![]() It would be nice to make this look plain and simple so that the developer can simply read what happened and doesn't get confused. E.g.:
Another thing is documentation. We should explain simple and short what is happening when someone spins up a local network with Pop Network. Both docs & output can be done in issue #57 as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looking forward to seeing it as a pop-node
command!
Interesting that the output includes Rococo, which should not be the case? |
#47