Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: async backing #7

Merged
merged 3 commits into from
Mar 10, 2024
Merged

feat: async backing #7

merged 3 commits into from
Mar 10, 2024

Conversation

evilrobot-01
Copy link
Collaborator

image

@evilrobot-01 evilrobot-01 force-pushed the frank/feat-async-backing branch from 470ab12 to 53e013e Compare March 9, 2024 11:05
@evilrobot-01 evilrobot-01 marked this pull request as ready for review March 9, 2024 11:05
@evilrobot-01 evilrobot-01 force-pushed the frank/feat-async-backing branch from 53e013e to 8021e1f Compare March 9, 2024 13:32
peterwht
peterwht approved these changes Mar 9, 2024
View reviewed changes
Copy link
Collaborator

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All phases correct. Looks good!

Daanvdplas
Daanvdplas approved these changes Mar 10, 2024
View reviewed changes
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vroooooooooommmmmm!!!! Testing this with pop was so nice

@evilrobot-01 evilrobot-01 merged commit f53a608 into main Mar 10, 2024
5 checks passed
@evilrobot-01 evilrobot-01 deleted the frank/feat-async-backing branch March 10, 2024 19:58
Daanvdplas added a commit that referenced this pull request Jun 20, 2024
@Daanvdplas
# This is a combination of 8 commits.
e81f78a 
# This is the 1st commit message:

refactor: general

# This is the commit message #2:

init

# This is the commit message #3:

begin refactor

# This is the commit message #4:

refactor: error handling

# This is the commit message #5:

tests: add error handling tests

# This is the commit message #6:

WIP

# This is the commit message #7:

finalise error handling

# This is the commit message #8:

refactor: easier review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daanvdplas Daanvdplas Daanvdplas approved these changes

@peterwht peterwht peterwht approved these changes

@al3mart al3mart Awaiting requested review from al3mart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evilrobot-01 @peterwht @Daanvdplas