Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add asset pallet suite + scheduler #9

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Add asset pallet suite + scheduler #9

merged 5 commits into from
Feb 27, 2024

Conversation

al3mart
Copy link
Collaborator

@al3mart al3mart commented Feb 26, 2024 •
edited by evilrobot-01
Loading

This merge request adds the following pallets:

  • pallet-nfts
  • pallet-nfts-runtime-api
  • pallet-nft-fractionalization
  • pallet-assets
  • pallet-scheduler --> Requires pallet-preimage

Closes: #8

@al3mart al3mart self-assigned this Feb 26, 2024
@al3mart al3mart mentioned this pull request Feb 26, 2024
Closed
5 tasks
evilrobot-01
evilrobot-01 reviewed Feb 26, 2024
View reviewed changes
Daanvdplas
Daanvdplas approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Ale

@al3mart
Copy link
Collaborator Author

al3mart commented Feb 27, 2024

I've addressed the comments and remove all included benchmarks in this same PR from pallets we don't maintain.

Daanvdplas
Daanvdplas approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to fix Franks comment, but other than that it is good to go

@al3mart al3mart requested a review from Daanvdplas February 27, 2024 20:47
evilrobot-01
evilrobot-01 reviewed Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

Mostly subtle tweaks and comments from me, but a few minor things which may warrant addressing.

@al3mart al3mart requested a review from evilrobot-01 February 27, 2024 21:37
evilrobot-01
evilrobot-01 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still change Assets in construct_runtime! to TrustBackedAssets but otherwise LGTM.

@evilrobot-01
Copy link
Collaborator

@al3mart Need to get commit signing sorted.

@evilrobot-01 evilrobot-01 merged commit 144c449 into main Feb 27, 2024
@evilrobot-01 evilrobot-01 deleted the al3mart/feat-add-pallets branch February 27, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwht peterwht peterwht approved these changes

@evilrobot-01 evilrobot-01 evilrobot-01 approved these changes

@Daanvdplas Daanvdplas Awaiting requested review from Daanvdplas

Assignees

@al3mart al3mart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add'em all!
4 participants
@al3mart @evilrobot-01 @peterwht @Daanvdplas