Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to H2 1.4.201 #163

Open
mp911de opened this issue May 25, 2020 · 3 comments
Open

Adapt to H2 1.4.201 #163

mp911de opened this issue May 25, 2020 · 3 comments
Assignees
@mp911de
Labels
type: task A general task

Comments

@mp911de
Copy link
Member

mp911de commented May 25, 2020

Building against the most recent H2 snapshots fails due to changes in the com.h2.value package.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project r2dbc-h2: Compilation failure: Compilation failure: 
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/ShortCodec.java:[21,20] cannot find symbol
[ERROR]   symbol:   class ValueShort
[ERROR]   location: package org.h2.value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/ByteCodec.java:[21,20] cannot find symbol
[ERROR]   symbol:   class ValueByte
[ERROR]   location: package org.h2.value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/IntegerCodec.java:[21,20] cannot find symbol
[ERROR]   symbol:   class ValueInt
[ERROR]   location: package org.h2.value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/ValueLobBlob.java:[27,20] cannot find symbol
[ERROR]   symbol:   class ValueLobDb
[ERROR]   location: package org.h2.value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/LongCodec.java:[21,20] cannot find symbol
[ERROR]   symbol:   class ValueLong
[ERROR]   location: package org.h2.value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/FloatCodec.java:[21,20] cannot find symbol
[ERROR]   symbol:   class ValueFloat
[ERROR]   location: package org.h2.value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/FloatCodec.java:[22,20] cannot find symbol
[ERROR]   symbol:   class ValueInt
[ERROR]   location: package org.h2.value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/BigDecimalCodec.java:[21,20] cannot find symbol
[ERROR]   symbol:   class ValueDecimal
[ERROR]   location: package org.h2.value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/BytesCodec.java:[21,20] cannot find symbol
[ERROR]   symbol:   class ValueBytes
[ERROR]   location: package org.h2.value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/StringCodec.java:[21,20] cannot find symbol
[ERROR]   symbol:   class ValueString
[ERROR]   location: package org.h2.value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/UuidCodec.java:[38,50] cannot find symbol
[ERROR]   symbol:   method getObject()
[ERROR]   location: class org.h2.value.Value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/ShortCodec.java:[31,33] cannot find symbol
[ERROR]   symbol:   variable SHORT
[ERROR]   location: class org.h2.value.Value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/ShortCodec.java:[41,16] cannot find symbol
[ERROR]   symbol:   variable ValueShort
[ERROR]   location: class io.r2dbc.h2.codecs.ShortCodec
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/ByteCodec.java:[31,33] cannot find symbol
[ERROR]   symbol:   variable BYTE
[ERROR]   location: class org.h2.value.Value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/ByteCodec.java:[41,16] cannot find symbol
[ERROR]   symbol:   variable ValueByte
[ERROR]   location: class io.r2dbc.h2.codecs.ByteCodec
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/BlobCodec.java:[63,50] incompatible types: org.h2.value.Value cannot be converted to org.h2.value.ValueLob
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/IntegerCodec.java:[31,28] cannot find symbol
[ERROR]   symbol:   variable ValueInt
[ERROR]   location: class io.r2dbc.h2.codecs.IntegerCodec
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/IntegerCodec.java:[41,16] cannot find symbol
[ERROR]   symbol:   variable ValueInt
[ERROR]   location: class io.r2dbc.h2.codecs.IntegerCodec
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/ClobCodec.java:[62,50] incompatible types: org.h2.value.Value cannot be converted to org.h2.value.ValueLob
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/GeometryCodec.java:[25,58] cannot find symbol
[ERROR]   symbol:   method getObject()
[ERROR]   location: class org.h2.value.Value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/ClobToStringCodec.java:[56,58] incompatible types: org.h2.value.Value cannot be converted to org.h2.value.ValueLob
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/LongCodec.java:[31,33] cannot find symbol
[ERROR]   symbol:   variable LONG
[ERROR]   location: class org.h2.value.Value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/LongCodec.java:[41,16] cannot find symbol
[ERROR]   symbol:   variable ValueLong
[ERROR]   location: class io.r2dbc.h2.codecs.LongCodec
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/FloatCodec.java:[32,28] cannot find symbol
[ERROR]   symbol:   variable ValueInt
[ERROR]   location: class io.r2dbc.h2.codecs.FloatCodec
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/FloatCodec.java:[42,16] cannot find symbol
[ERROR]   symbol:   variable ValueFloat
[ERROR]   location: class io.r2dbc.h2.codecs.FloatCodec
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/BigDecimalCodec.java:[33,33] cannot find symbol
[ERROR]   symbol:   variable DECIMAL
[ERROR]   location: class org.h2.value.Value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/BigDecimalCodec.java:[43,16] cannot find symbol
[ERROR]   symbol:   variable ValueDecimal
[ERROR]   location: class io.r2dbc.h2.codecs.BigDecimalCodec
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/LocalDateCodec.java:[22,39] method valueToLocalDate in class org.h2.util.JSR310Utils cannot be applied to given types;
[ERROR]   required: org.h2.value.Value,org.h2.engine.CastDataProvider
[ERROR]   found: org.h2.value.Value
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/BytesCodec.java:[31,33] cannot find symbol
[ERROR]   symbol:   variable BYTES
[ERROR]   location: class org.h2.value.Value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/BytesCodec.java:[41,16] cannot find symbol
[ERROR]   symbol:   variable ValueBytes
[ERROR]   location: class io.r2dbc.h2.codecs.BytesCodec
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/BlobToByteBufferCodec.java:[69,50] incompatible types: org.h2.value.Value cannot be converted to org.h2.value.ValueLob
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/LocalTimeCodec.java:[22,39] method valueToLocalTime in class org.h2.util.JSR310Utils cannot be applied to given types;
[ERROR]   required: org.h2.value.Value,org.h2.engine.CastDataProvider
[ERROR]   found: org.h2.value.Value
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/StringCodec.java:[31,21] cannot find symbol
[ERROR]   symbol:   variable STRING
[ERROR]   location: class org.h2.value.Value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/StringCodec.java:[32,18] cannot find symbol
[ERROR]   symbol:   variable STRING_FIXED
[ERROR]   location: class org.h2.value.Value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/StringCodec.java:[33,18] cannot find symbol
[ERROR]   symbol:   variable STRING_IGNORECASE
[ERROR]   location: class org.h2.value.Value
[ERROR] /Users/mpaluch/git/r2dbc/r2dbc-h2/src/main/java/io/r2dbc/h2/codecs/StringCodec.java:[43,16] cannot find symbol
[ERROR]   symbol:   variable ValueString
[ERROR]   location: class io.r2dbc.h2.codecs.StringCodec
[ERROR] -> [Help 1]
@mp911de mp911de added the type: task A general task label May 25, 2020
@mp911de mp911de self-assigned this May 25, 2020
mp911de added a commit that referenced this issue May 25, 2020
@mp911de
Adapt to H2 1.4.201
7b817b1 
Add also script to test against next H2 version.

[#163]
@katzyn
Copy link

katzyn commented May 29, 2020

I think H2StatementTest should use standard GENERATED BY DEFAULT AS IDENTITY instead of MySQL compatibility AUTO_INCREMENT.

@mp911de
Copy link
Member Author

mp911de commented May 29, 2020

Thanks for the heads-up. @katzyn do you have a schedule for the 1.4.201 release? Even a rough one would be fine.

@katzyn
Copy link

katzyn commented May 29, 2020

H2 is simply released from time to time, there is no schedule. Thomas pushed some release preparation changes about a month ago, but didn't make a release, most likely due to lack of time.

gregturn added a commit that referenced this issue Jan 14, 2021
@gregturn
Use GENERATED BY DEFAULT AS IDENTITY instead of AUTO_INCREMENT.
001ee8d 
Based on feedback, switch incrementing logic.

See also: #163 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: task A general task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mp911de @katzyn