Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapped in ConnectionPool unwrapping doesn't guard against implementations returning this #220

Closed
mp911de opened this issue Nov 28, 2024 · 0 comments
Closed

Wrapped in ConnectionPool unwrapping doesn't guard against implementations returning this #220

mp911de opened this issue Nov 28, 2024 · 0 comments
Assignees
@mp911de
Labels
type: regression A regression from a previous release
Milestone
1.0.3.RELEASE

Comments

@mp911de
Copy link
Member

mp911de commented Nov 28, 2024

This is a regression introduced by #217

java.lang.ClassCastException: class io.r2dbc.postgresql.PostgresqlConnection cannot be cast to class reactor.core.scheduler.Scheduler (io.r2dbc.postgresql.PostgresqlConnection and reactor.core.scheduler.Scheduler are in unnamed module of loader 'app')
	at io.r2dbc.pool.ConnectionPool.lambda$null$4(ConnectionPool.java:118) ~[r2dbc-pool-1.0.2.RELEASE.jar:1.0.2.RELEASE]
	at reactor.core.publisher.MonoFlatMap$FlatMapMain.onNext(MonoFlatMap.java:132) ~[reactor-core-3.6.12.jar:3.6.12]
	... 208 common frames omitted
@mp911de mp911de added the type: regression A regression from a previous release label Nov 28, 2024
@mp911de mp911de added this to the 1.0.3.RELEASE milestone Nov 28, 2024
@mp911de mp911de self-assigned this Nov 28, 2024
mp911de added a commit that referenced this issue Nov 28, 2024
@mp911de
Guard Executor/Scheduler unwrapping against implementations returning…
0174898 
… themselves.

If unwrap isn't able to unwrap then it would return itself causing a cast exception.

[resolves #220]

Signed-off-by: Mark Paluch <mark.paluch@broadcom.com>
@mp911de mp911de mentioned this issue Nov 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
1.0.3.RELEASE
Development

No branches or pull requests
1 participant
@mp911de