Refactor client to make it handle events correctly (according to the spec.) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreydwalter
force-pushed
the
master
branch
2 times, most recently
from
b3d5eeb to
375d4a1
Compare
jeffreydwalter
commented
Sep 18, 2018
jeffreydwalter
force-pushed
the
master
branch
2 times, most recently
from
c47057e to
aabe2ae
Compare
jeffreydwalter
force-pushed
the
master
branch
from
aabe2ae to
98b5b7d
Compare
|
Is this PR still WIP, or are you happy to have it reviewed/merged? |
|
I think that it's good enough to merge. It makes the client parse events properly, which will make it useable for people. I will submit another PR for the retry stuff. I'll probably leave the unit tests up to you. (I don't have a lot of free time to write them.) |
purehyperbole
approved these changes
Sep 18, 2018
|
Great, all looks good. Thanks again for contributing this, it's greatly improved the quality library :) I'm going to update the testing suite to use Testify, so i'll add the additional unit tests then. |
|
Awesome! My pleasure and thank you for putting the library together! I'll get a PR together for the retry stuff soon. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the client more closely following the spec (see #33 for more details).
This work does not address the
retryfunctionality nor unit tests for the change in behavior. That being said, all existing unit tests pass.