Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake configuration for MSVC #3

Closed

Conversation

oocytanb
Copy link
Contributor

@oocytanb oocytanb commented Jun 7, 2021

This PR will enable to build on Windows MSVC.

My environment:

  • Windows 10 (x64)
  • Visual Studio 2019

@r9y9
Copy link
Owner

r9y9 commented Jun 10, 2021

Thanks for doing this! We'd need to update CI for this repo using Github actions like https://github.com/r9y9/sinsy/blob/d8fd837b2ff1bd2e03f98e9e53d36c19e491d5ea/.github/workflows/ccpp.yaml.

If you can look into it, that would be great. Or I may look into it when I get some time.

@oocytanb
Copy link
Contributor Author

Thank you for your reply.
I am trying to make configuration for GitHub actions.
See PR #4

@oocytanb
Copy link
Contributor Author

PR #4 のマージありがとうございます。
こちらは Close させていただきますね。

@oocytanb oocytanb closed this Jun 15, 2021
tsukumijima pushed a commit to tsukumijima/open_jtalk that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants