Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Fix requires numpy version #59

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

sabonerune
Copy link
Contributor

I add oldest-supported-numpy in #45 .
But numpy1.25 added backward compatibility for C-API.

Note

Before NumPy 1.25, the NumPy C-API was not backwards compatible. This means that when compiling with a NumPy version earlier than 1.25 you have to compile with the oldest version you wish to support. This can be done by using oldest-supported-numpy. Please see the NumPy 1.24 documentation.

In addition to that, a description about Numpy 2 was added.

Note

At the time of NumPy 1.25, NumPy 2.0 is expected to be the next release of NumPy. The NumPy 2.0 release is expected to require a different pin, since NumPy 2+ will be needed in order to be compatible with both NumPy 1.x and 2.x.

This PR will change to use the latest Numpy in Python 3.9 or later environments that support Numpy 1.25 or later.
I think this makes it more compatible with Numpy 2.

Copy link
Owner

@r9y9 r9y9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@r9y9 r9y9 merged commit c5a693a into r9y9:master Jul 27, 2023
6 checks passed
@sabonerune sabonerune deleted the enh/support-np2 branch July 27, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants