Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking cmake is in the system path for windows #64

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

YCHuang2112sub
Copy link

From time to time, people on windows suffer compiling error, file not found. But not showing what files, so I add a checking of the cmake in the begging since the cmake is required but not necessary exist on windows sys path.

Copy link
Owner

@r9y9 r9y9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your contribution! Could you address my comment? I'll merge if that's fixed

.vscode/settings.json Outdated Show resolved Hide resolved
@r9y9 r9y9 merged commit c8cfc62 into r9y9:master Aug 21, 2023
6 checks passed
@r9y9
Copy link
Owner

r9y9 commented Aug 21, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants